tools: Consolidate upload() function

Signed-off-by: Matt Turner <mattst88@gentoo.org>

tools/catalyst-auto

@@ -47,7 +47,6 @@ Options:
   --interval <days>   Exit if last successful run was less than <days> ago
   -l|--lock <file>    File to grab a lock on to prevent multiple invocations
   -X|--nonetwork      Do not perform network operations (like uploading result)
-                      This needs to be supported by the config file as well.
   -h|--help           Show this message and quit
 
 EOH
@@ -270,6 +269,29 @@ verify_dnssec() {
     fi
 }
 
+upload() {
+	if [[ ${nonetwork} == 0 ]]; then
+		echo Uploading "$@"
+		local SSH_CMD=(
+			ssh
+			-i ${UPLOAD_KEY}
+			-o UserKnownHostsFile=/dev/null
+			-o VerifyHostKeyDNS=yes
+			-o StrictHostKeyChecking=no
+		)
+		local RSYNC_OPTS=(
+			-e "${SSH_CMD[*]}"
+			--archive
+			--omit-dir-times
+			--delay-updates
+		)
+		rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
+	else
+		echo Would now upload "$@"
+		ls -l $@
+	fi
+}
+
 run_catalyst_commands() {
 	doneconfig=0
 	for config_file in "${config_files[@]}"; do

tools/catalyst-auto-alpha.conf

@@ -33,24 +33,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	echo Uploading "$@"
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-amd64.conf

@@ -65,24 +65,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	echo " ** Uploading $@"
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-arm.conf

@@ -54,29 +54,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-    if [[ ${nonetwork} == 0 ]]; then
-	echo Uploading "$@"
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-    else
-	echo Would now upload "$@"
-	ls -l $@
-    fi
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-arm64.conf

@@ -28,23 +28,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-hppa.conf

@@ -34,23 +34,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-ia64.conf

@@ -27,23 +27,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-ppc.conf

@@ -32,23 +32,6 @@ update_symlinks() {
 		popd >/dev/null
 	done
 }
-
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
  
 post_build() {
 	local set=$1 spec=$2

tools/catalyst-auto-ppc64le.conf

@@ -34,23 +34,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-qemu-arm.conf

@@ -55,29 +55,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-    if [[ ${nonetwork} == 0 ]]; then
-	echo Uploading "$@"
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-    else
-	echo Would now upload "$@"
-	ls -l $@
-    fi
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-qemu-riscv.conf

@@ -42,26 +42,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-    if [[ ${nonetwork} == 0 ]]; then
-	echo Uploading "$@"
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-    fi
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-s390.conf

@@ -27,23 +27,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-s390x.conf

@@ -27,23 +27,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-sparc64.conf

@@ -29,23 +29,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2
 

tools/catalyst-auto-x86.conf

@@ -52,24 +52,6 @@ update_symlinks() {
 	done
 }
 
-upload() {
-	echo " ** Uploading $@"
-	local SSH_CMD=(
-		ssh
-		-i ${UPLOAD_KEY}
-		-o UserKnownHostsFile=/dev/null
-		-o VerifyHostKeyDNS=yes
-		-o StrictHostKeyChecking=no
-	)
-	local RSYNC_OPTS=(
-		-e "${SSH_CMD[*]}"
-		--archive
-		--omit-dir-times
-		--delay-updates
-	)
-	rsync "${RSYNC_OPTS[@]}" "$@" ${UPLOAD_USER}@releng-incoming.gentoo.org:${UPLOAD_DEST}
-}
-
 post_build() {
 	local set=$1 spec=$2